StreamReader/Writer are disposing Request/Response body #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st body when closing StreamWriter/Reader
MangelMaxime
reviewed
Nov 8, 2019
| @@ -53,7 +53,7 @@ type ThothSerializer (?isCamelCase : bool, ?extra : ExtraCoders, ?skipNullField | |||
|
|
|||
| static member ReadBodyRaw (ctx: HttpContext) = | |||
| task { | |||
| use stream = new System.IO.StreamReader(ctx.Request.Body, Utf8EncodingWithoutBom) | |||
| use stream = new System.IO.StreamReader(ctx.Request.Body, Utf8EncodingWithoutBom, true, DefaultBufferSize, true) | |||
There was a problem hiding this comment.
Hello @MaxDeg ,
I don't know the SteamReaderAPI, why is this one having 3 new parameters instead of just one like the others?
Should we use the 3 parameters or use something like ?leaveOpen = true?
There was a problem hiding this comment.
Hello,
Sadly StreamReader only have one constructor that allow to provide leaveOpen option as last parameter. None of those parameters are optional so we need to provide them all.
|
Thank you, Released as version 3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of use on the
StreamReaderandStreamWriteris disposing the Body. This is causing issue if middleware are trying to use it afterward.I think it's best to not dispose Stream that we do not own.
This fix the issue. I just added the leaveOpen parameter to the reader/writer to not close inner stream on dispose